Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for out of band access tokens in the GCS Client #11181

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for out of band access tokens in the GCS Client #11181

wants to merge 4 commits into from

Conversation

ArnavBalyan
Copy link

  • Currently the GCS client supports only keyfiles for credential based authentication. (However this is not always safe and many usecases leverage access tokens for storage access).
  • This change adds support for access token based authentication when interacting with GCS.
  • Access tokens can be fetched using an out of band fetch mechanism such as token-broker service or a custom token provider.
  • This change adds the contract and ability to use access tokens, the user must bundle their custom token provider which can interact with internal systems and provide an access token on demand.

@facebook-github-bot
Copy link
Contributor

Hi @ArnavBalyan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@netlify Netlify
Copy link

netlify bot commented Oct 7, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit ca77f06
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67037c26042efc000851ec12

@ArnavBalyan ArnavBalyan changed the title [Velox] Add support for out of band access tokens in the GCS Client Add support for out of band access tokens in the GCS Client Oct 7, 2024
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArnavBalyan @facebook-github-bot